[webkit-reviews] review granted: [Bug 202506] Resource Load Statistics: Downgrade document.referrer for all third-party iframes : [Attachment 380144] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted John Wilander
<wilander at apple.com>'s request for review:
Bug 202506: Resource Load Statistics: Downgrade document.referrer for all
third-party iframes
https://bugs.webkit.org/show_bug.cgi?id=202506

Attachment 380144: Patch

https://bugs.webkit.org/attachment.cgi?id=380144&action=review




--- Comment #7 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 380144
  --> https://bugs.webkit.org/attachment.cgi?id=380144
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380144&action=review

Looks like a good change. It seems like some code could be consolidated.

> Source/WebCore/dom/Document.cpp:4858
> +		   return m_referrerOverride;

Could this just call 'Document::downgradeReferrerToRegistrableDomain()'? Or
could this code be shared with that method?

> LayoutTests/http/tests/media/media-stream/enumerate-devices-source-id.html:12
> +		   internals.setResourceLoadStatisticsEnabled(false);

Lol. So many tests need ITP off. :-)