[webkit-reviews] review denied: [Bug 202490] CMake-built WebKit.framework should launch XPC services successfully : [Attachment 380124] Patch

[bugzilla-daemon at webkit.org]

Konstantin Tokarev <annulen at yandex.ru> has denied  review:
Bug 202490: CMake-built WebKit.framework should launch XPC services
successfully
https://bugs.webkit.org/show_bug.cgi?id=202490

Attachment 380124: Patch

https://bugs.webkit.org/attachment.cgi?id=380124&action=review




--- Comment #8 from Konstantin Tokarev <annulen at yandex.ru> ---
Comment on attachment 380124
  --> https://bugs.webkit.org/attachment.cgi?id=380124
Patch

I don't agree with this fix, for reasons mentioned above. Things specific to
Mac port should go to PlatformMac.cmake, not spread around. Also, if (APPLE)
condition will be true for WebKitGTK on macOS, which may have undesirable
consequences.