[webkit-reviews] review granted: [Bug 202530] [GTK] WebAutomation: make setWindowRect synchronous : [Attachment 380119] Patch

[bugzilla-daemon at webkit.org]

Carlos Alberto Lopez Perez <clopez at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 202530: [GTK] WebAutomation: make setWindowRect synchronous
https://bugs.webkit.org/show_bug.cgi?id=202530

Attachment 380119: Patch

https://bugs.webkit.org/attachment.cgi?id=380119&action=review




--- Comment #3 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
Comment on attachment 380119
  --> https://bugs.webkit.org/attachment.cgi?id=380119
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380119&action=review

> Source/WebKit/UIProcess/API/glib/WebKitUIClient.cpp:156
> +	       if (geometry.x >= 0 && geometry.y >= 0) {

curly braces are not needed around this if.

> Source/WebKit/UIProcess/API/glib/WebKitUIClient.cpp:159
> +	       if (geometry.width > 0 && geometry.height > 0) {

Same here.