[webkit-reviews] review granted: [Bug 202521] http/tests/security/navigate-when-restoring-cached-page.html should not use RTCPeerConnection to not enter in page cache : [Attachment 380106] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 3 08:28:41 PDT 2019


Chris Dumez <cdumez at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 202521: http/tests/security/navigate-when-restoring-cached-page.html should
not use RTCPeerConnection to not enter in page cache
https://bugs.webkit.org/show_bug.cgi?id=202521

Attachment 380106: Patch

https://bugs.webkit.org/attachment.cgi?id=380106&action=review




--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 380106
  --> https://bugs.webkit.org/attachment.cgi?id=380106
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380106&action=review

r=me with comments.

> Source/WebCore/testing/Internals.cpp:931
> +class CannotSuspendActiveDOMObject final : public ActiveDOMObject, public
RefCounted<CannotSuspendActiveDOMObject> {

CannotSuspendActiveDOMObject -> UnsuspendableActiveDOMObject

> Source/WebCore/testing/Internals.h:906
> +    RefPtr<CannotSuspendActiveDOMObject> m_cannotSuspendActiveDOMObject;

m_unsuspendableActiveDOMObject.


More information about the webkit-reviews mailing list