[webkit-reviews] review granted: [Bug 202502] Fix a bug that warning icon causes infinite rendering when it has warning message. : [Attachment 380080] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted dewei_zhu at apple.com's request for
review:
Bug 202502: Fix a bug that warning icon causes infinite rendering when it has
warning message.
https://bugs.webkit.org/show_bug.cgi?id=202502

Attachment 380080: Patch

https://bugs.webkit.org/attachment.cgi?id=380080&action=review




--- Comment #4 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 380080
  --> https://bugs.webkit.org/attachment.cgi?id=380080
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380080&action=review

>
Websites/perf.webkit.org/public/v3/components/test-group-revision-table.js:122
> +	       warningIcon.setButtonTitle(`Last status:
${request.statusDescription()}`);

It's a bit strange to call setButtonTitle on WarningIcon.
I think we should add a method like setWarning on WarningIcon itself, which is
a trivial forwarding to setButtonTitle.