[webkit-reviews] review granted: [Bug 202487] Web Inspector: remove `InspectorInstrumentationCookie` : [Attachment 380048] Patch

[bugzilla-daemon at webkit.org]

Matt Baker <mattbaker at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 202487: Web Inspector: remove `InspectorInstrumentationCookie`
https://bugs.webkit.org/show_bug.cgi?id=202487

Attachment 380048: Patch

https://bugs.webkit.org/attachment.cgi?id=380048&action=review




--- Comment #2 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 380048
  --> https://bugs.webkit.org/attachment.cgi?id=380048
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380048&action=review

r=me, nice refactor.

> Source/WebCore/inspector/InspectorInstrumentation.cpp:401
> +	   return;

Breaking out this early return is nice. :)

> Source/WebCore/inspector/InspectorInstrumentation.h:835
> +

There is an empty line after FAST_RETURN_IF_NO_FRONTENDS here, and below (843),
but not elsewhere. We should be consistent.