[webkit-reviews] review granted: [Bug 202493] FTL OSR exit shouldn't bother updating get_by_id array profiles that have changed modes : [Attachment 380058] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 202493: FTL OSR exit shouldn't bother updating get_by_id array profiles
that have changed modes
https://bugs.webkit.org/show_bug.cgi?id=202493

Attachment 380058: Patch

https://bugs.webkit.org/attachment.cgi?id=380058&action=review




--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 380058
  --> https://bugs.webkit.org/attachment.cgi?id=380058
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380058&action=review

> Source/JavaScriptCore/ftl/FTLOSRExitCompiler.cpp:256
> +		   if (instruction->opcodeID() == op_get_by_id) {

do you want to do the is<OpGetById> instead?