[webkit-reviews] review denied: [Bug 200764] Main implementation for lazy image loading : [Attachment 379149] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Rob Buis
<rbuis at igalia.com>'s request for review:
Bug 200764: Main implementation for lazy image loading
https://bugs.webkit.org/show_bug.cgi?id=200764

Attachment 379149: Patch

https://bugs.webkit.org/attachment.cgi?id=379149&action=review




--- Comment #66 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 379149
  --> https://bugs.webkit.org/attachment.cgi?id=379149
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379149&action=review

> Source/WebCore/html/LazyLoadImageObserver.cpp:88
> +    Document* document = rootDocument(element);
> +    if (!document)
> +	   return;
> +    auto& observer = document->lazyLoadImageObserver();
> +    auto* intersectionObserver = observer.intersectionObserver(*document);
> +    if (!intersectionObserver)
> +	   return;
> +    intersectionObserver->observe(element);

I still think you should have an IntersectionObserver per frame, not always use
a single observer in the root document. Crossing document boundaries like this
is a source of bugs.