[webkit-reviews] review granted: [Bug 202446] Web Inspector: REGRESSION(r250149): changing CSS via the Styles details sidebar panel doesn't update the associated resource : [Attachment 380027] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 202446: Web Inspector: REGRESSION(r250149): changing CSS via the Styles
details sidebar panel doesn't update the associated resource
https://bugs.webkit.org/show_bug.cgi?id=202446

Attachment 380027: Patch

https://bugs.webkit.org/attachment.cgi?id=380027&action=review




--- Comment #3 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 380027
  --> https://bugs.webkit.org/attachment.cgi?id=380027
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380027&action=review

r=me. Layout Test failures don't appear to be caused by this.

> Source/WebInspectorUI/UserInterface/Models/SourceCode.js:227
> +	   if (this._currentRevision === this._originalRevision)
> +	       this.currentRevision = this._originalRevision.copy();

Hmm, should we just do this in the constructor (and LocalResource constructor)?
I tried to lazy avoid the copy, but if they share the same string it ins't
really a "copy" so we would probably be fine.