[webkit-reviews] review granted: [Bug 202372] Updated resource load statistics are never merged into the SQLite Database backend : [Attachment 379975] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Katherine_cheney at apple.com's
request for review:
Bug 202372: Updated resource load statistics are never merged into the SQLite
Database backend
https://bugs.webkit.org/show_bug.cgi?id=202372

Attachment 379975: Patch

https://bugs.webkit.org/attachment.cgi?id=379975&action=review




--- Comment #16 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 379975
  --> https://bugs.webkit.org/attachment.cgi?id=379975
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379975&action=review

Looks good. Please flip the public/private on that handful of statements and I
think we're good here.

>
Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp
:220
> +	   RELEASE_LOG_ERROR(Network, "%p -
ResourceLoadStatisticsDatabaseStore::open failed, error message: %{private}s,
database path: %{private}s", this, m_database.lastErrorMsg(),
m_storageDirectoryPath.utf8().data());

This can be %public. The location of the database file is not private
information.

>
Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp
:230
> +	       RELEASE_LOG_ERROR(Network, "%p -
ResourceLoadStatisticsDatabaseStore::createSchema failed, error message:
%{private}s, database path: %{private}s", this, m_database.lastErrorMsg(),
m_storageDirectoryPath.utf8().data());

This can be %public. This just creates empty tables, and error messages about
that is not private information.

>
Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp
:240
> +	   RELEASE_LOG_ERROR(Network, "%p -
ResourceLoadStatisticsDatabaseStore::prepareStatements failed, error message:
%{private}s, database path: %{private}s", this, m_database.lastErrorMsg(),
m_storageDirectoryPath.utf8().data());

This can be %public. This just prepares parameterized SQL statements, which
does not contain private information.

>
Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp
:358
> +	   RELEASE_LOG_ERROR(Network, "%p -
ResourceLoadStatisticsDatabaseStore::prepareStatements failed to prepare, error
message: %{private}s", this, m_database.lastErrorMsg());

The prepare-statement error messages can go in %public. There is not private
information in this query (just creating empty tables and preparing SQL calls).