[webkit-reviews] review granted: [Bug 201616] WebKitTestRunner: Many tests timeout on macOS Catalina : [Attachment 379954] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 1 16:43:07 PDT 2019


Alexey Proskuryakov <ap at webkit.org> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 201616: WebKitTestRunner: Many tests timeout on macOS Catalina
https://bugs.webkit.org/show_bug.cgi?id=201616

Attachment 379954: Patch

https://bugs.webkit.org/attachment.cgi?id=379954&action=review




--- Comment #10 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 379954
  --> https://bugs.webkit.org/attachment.cgi?id=379954
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379954&action=review

> Source/WTF/wtf/Platform.h:1387
> +#if (PLATFORM(MAC) && defined USE_APPLE_INTERNAL_SDK &&
__MAC_OS_X_VERSION_MIN_REQUIRED >= 101500) || PLATFORM(IOS_FAMILY)

This should be USE(APPLE_INTERNAL_SDK), not USE_APPLE_INTERNAL_SDK.


More information about the webkit-reviews mailing list