[webkit-reviews] review granted: [Bug 202435] Storage Access API: document.hasStorageAccess() should return true when the cookie policy allows access : [Attachment 379962] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 1 16:09:37 PDT 2019


Brent Fulgham <bfulgham at webkit.org> has granted John Wilander
<wilander at apple.com>'s request for review:
Bug 202435: Storage Access API: document.hasStorageAccess() should return true
when the cookie policy allows access
https://bugs.webkit.org/show_bug.cgi?id=202435

Attachment 379962: Patch

https://bugs.webkit.org/attachment.cgi?id=379962&action=review




--- Comment #4 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 379962
  --> https://bugs.webkit.org/attachment.cgi?id=379962
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379962&action=review

Looks reasonable. I think you left some partially-written code in one section.
If r=me (ews)

>
Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:448
> +    }

This little section seems unneeded.


More information about the webkit-reviews mailing list