[webkit-reviews] review granted: [Bug 202409] [CSS Shadow Parts] Parse 'part' attribute : [Attachment 379943] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 1 13:41:30 PDT 2019


Ryosuke Niwa <rniwa at webkit.org> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 202409: [CSS Shadow Parts] Parse 'part' attribute
https://bugs.webkit.org/show_bug.cgi?id=202409

Attachment 379943: patch

https://bugs.webkit.org/attachment.cgi?id=379943&action=review




--- Comment #6 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 379943
  --> https://bugs.webkit.org/attachment.cgi?id=379943
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379943&action=review

> Source/WebCore/dom/Element.cpp:1723
> +	   else if (name == HTMLNames::partAttr)
> +	       partAttributeChanged(newValue);

Add a runtime check?


More information about the webkit-reviews mailing list