[webkit-reviews] review granted: [Bug 202396] Queue events and promise resolution in RTCPeerConnection when suspended for page cache : [Attachment 379886] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 202396: Queue events and promise resolution in RTCPeerConnection when
suspended for page cache
https://bugs.webkit.org/show_bug.cgi?id=202396

Attachment 379886: Patch

https://bugs.webkit.org/attachment.cgi?id=379886&action=review




--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 379886
  --> https://bugs.webkit.org/attachment.cgi?id=379886
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379886&action=review

> Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:632
> +void RTCPeerConnection::fireEvent(Ref<Event>&& event)

I don't really like the name fireEvent(), I do not think it makes it clear what
the difference with dispatchEvent() is. I suggest dispatchEventWhenPossible()
or dispatchEventWhenAllowed()