[webkit-reviews] review denied: [Bug 197597] Web Inspector: replace UIString key with comment : [Attachment 369089] Patch

[bugzilla-daemon at webkit.org]

Brian Burg <bburg at apple.com> has denied Devin Rousso <drousso at apple.com>'s
request for review:
Bug 197597: Web Inspector: replace UIString key with comment
https://bugs.webkit.org/show_bug.cgi?id=197597

Attachment 369089: Patch

https://bugs.webkit.org/attachment.cgi?id=369089&action=review




--- Comment #5 from Brian Burg <bburg at apple.com> ---
Comment on attachment 369089
  --> https://bugs.webkit.org/attachment.cgi?id=369089
Patch

While callsites are a bit shorter, I don't think this is a good change.
Whenever a comment string changes or is added, localizers would need to
re-localize the key, because the comment string becomes the key.

Unrelated, but I find the @ [Location] formatting to be confusing. Most
localization files I've seen on macOS use the format "Search: (Settings tab)"
rather than "Search: @ Settings"