[webkit-reviews] review granted: [Bug 202250] Add support for the Wasm multi-value proposal : [Attachment 379842] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 1 08:22:49 PDT 2019


Saam Barati <sbarati at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 202250: Add support for the Wasm multi-value proposal
https://bugs.webkit.org/show_bug.cgi?id=202250

Attachment 379842: Patch

https://bugs.webkit.org/attachment.cgi?id=379842&action=review




--- Comment #13 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 379842
  --> https://bugs.webkit.org/attachment.cgi?id=379842
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379842&action=review

r=me

> Source/JavaScriptCore/wasm/WasmAirIRGenerator.cpp:864
> +    CallInformation wasmCC =
wasmCallingConvention().callLocationsFor(signature, CallRole::Callee);

Still not a fan of the name “callLocatjonsFor”


More information about the webkit-reviews mailing list