[webkit-reviews] review granted: [Bug 204082] Implement GetByVal inline caching for 32-bit JITs : [Attachment 384290] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Nov 30 16:36:39 PST 2019

Saam Barati <sbarati at apple.com> has granted Caio Lima <ticaiolima at gmail.com>'s
request for review:
Bug 204082: Implement GetByVal inline caching for 32-bit JITs

Attachment 384290: Patch


--- Comment #6 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 384290
  --> https://bugs.webkit.org/attachment.cgi?id=384290

View in context: https://bugs.webkit.org/attachment.cgi?id=384290&action=review

Nice. r=me

> Source/JavaScriptCore/bytecode/StructureStubInfo.h:223
>	   GPRReg baseTagGPR;

This isn’t your patch, but I wonder why this is needed. I think all users of
StructureStubInfo branch around the base being a cell. But it might be worth
looking at to verify and perhaps remove in the future.

> Source/JavaScriptCore/bytecode/StructureStubInfo.h:224
> +	   union {

Why not put this in “u”?

More information about the webkit-reviews mailing list