[webkit-reviews] review granted: [Bug 203898] Add FuzzerAgent that reads predictions from a file : [Attachment 384346] proposed patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Tuomas Karkkainen
<tuomas.webkit at apple.com>'s request for review:
Bug 203898: Add FuzzerAgent that reads predictions from a file
https://bugs.webkit.org/show_bug.cgi?id=203898

Attachment 384346: proposed patch

https://bugs.webkit.org/attachment.cgi?id=384346&action=review




--- Comment #21 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 384346
  --> https://bugs.webkit.org/attachment.cgi?id=384346
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384346&action=review

r=me with a couple nits

> Source/JavaScriptCore/runtime/FuzzerPredictions.cpp:33
> +    FILE* f = fopen(fileName, "r");

Nit: in WebKit style, we tend to avoid single letter variable names. I think a
name more inline with the style guide would be “file”

> Source/JavaScriptCore/runtime/OptionsList.h:402
> +    v(OptionString, fuzzerPredictions, nullptr, Normal, "file with list of
predictions for FileBasedFuzzerAgent") \

Maybe “fuzzerPredictionsPath” or “fuzzerPredictionsFile”?

> Source/WTF/ChangeLog:3
> +	   add ASSERT_NOT_REACHED_WITH_MESSAGE and
RELEASE_ASSERT_NOT_REACHED_WITH_MESSAGE

Delete this changelog in your diff. I think you already did this in another
patch