[webkit-reviews] review granted: [Bug 204714] Move path implementation functions in LineLayoutTraversal to *Path classes : [Attachment 384541] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Nov 30 06:49:31 PST 2019

Sam Weinig <sam at webkit.org> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 204714: Move path implementation functions in LineLayoutTraversal to *Path

Attachment 384541: patch


--- Comment #5 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 384541
  --> https://bugs.webkit.org/attachment.cgi?id=384541

View in context: https://bugs.webkit.org/attachment.cgi?id=384541&action=review

> Source/WebCore/rendering/line/LineLayoutTraversalComplexPath.h:39
> +	   , m_sortedInlineTextBoxes(WTFMove(sortedInlineTextBoxes))

We do this all over, so maybe there is a good reason for it, but I don't think
this WTFMove() is necessary. sortedInlineTextBoxes is already an rvalue, so the
move constructor of m_sortedInlineTextBoxes should be used regardless.

> Source/WebCore/rendering/line/LineLayoutTraversalSimplePath.h:69
> +	   // FIXME: SLL can contains <br> runs and this should skip over them.

I would spell out SimpleLineLayout here instead of using SSL, took me a minute
to figure out what it meant.

More information about the webkit-reviews mailing list