[webkit-reviews] review granted: [Bug 204704] [EWS] Do not retry layout-tests build if the flaky test failures are also present in clean tree run : [Attachment 384510] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 204704: [EWS] Do not retry layout-tests build if the flaky test failures
are also present in clean tree run
https://bugs.webkit.org/show_bug.cgi?id=204704

Attachment 384510: Patch

https://bugs.webkit.org/attachment.cgi?id=384510&action=review




--- Comment #2 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 384510
  --> https://bugs.webkit.org/attachment.cgi?id=384510
Patch

This is clearly an improvement, it's obvious that a patch with results like
these should get a green bubble. I think that we are still too strict with
declaring SUCCESS, and delay the verdict unnecessarily.

One thing that doesn't make logical sense to me is that we completely ignore
flaky tests if they pass on retry within a single test run - but tests that
also fail on retry within the run yet pass on a new run are treated as ultra
important.