[webkit-reviews] review granted: [Bug 204694] [Win] Retrieve all following WM_CHAR events at the beginning of processing WM_KEYDOWN event : [Attachment 384492] Patch

[bugzilla-daemon at webkit.org]

Ross Kirsling <ross.kirsling at sony.com> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 204694: [Win] Retrieve all following WM_CHAR events at the beginning of
processing WM_KEYDOWN event
https://bugs.webkit.org/show_bug.cgi?id=204694

Attachment 384492: Patch

https://bugs.webkit.org/attachment.cgi?id=384492&action=review




--- Comment #6 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 384492
  --> https://bugs.webkit.org/attachment.cgi?id=384492
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384492&action=review

r=me but let's change the naming somehow.

>>>> Source/WebKit/ChangeLog:25
>>>> +	      Test: Covered by existing
fast/events/inputText-never-fired-on-keydown-cancel.html and
fast/events/keydown-keypress-preventDefault.html
>>> 
>>> Shouldn't there be some update to TestExpectations then?
>> 
>> No. These tests are failing only for WinCairo WebKit2.
> 
> I mean these test aren’t marked as Failure.

I see. We sure do need a test bot, hehe...

> Source/WebKit/Shared/NativeWebKeyboardEvent.h:110
> +    Vector<MSG> m_followingCharEvents;

I think "pending" might be a better word.

(followingCharEvents kind of reads like isFollowingCharEvents with the "is"
dropped. "subsequent" might also work if you really want to say "comes after"
and not "yet to be processed".)