[webkit-reviews] review granted: [Bug 204668] Cache integer font metrics for performance : [Attachment 384445] patch

[bugzilla-daemon at webkit.org]

zalan <zalan at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s request
for review:
Bug 204668: Cache integer font metrics for performance
https://bugs.webkit.org/show_bug.cgi?id=204668

Attachment 384445: patch

https://bugs.webkit.org/attachment.cgi?id=384445&action=review




--- Comment #2 from zalan <zalan at apple.com> ---
Comment on attachment 384445
  --> https://bugs.webkit.org/attachment.cgi?id=384445
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384445&action=review

> Source/WebCore/ChangeLog:8
> +	   Line layout uses integer metrics and queries them a lot. Avoid
repeated rounding.

Eventually IFC (or any line layout system really) should call the float flavor
and do proper snapping at the line level.