[webkit-reviews] review granted: [Bug 204674] [GStreamer] Convert GLVideoSink and WebKitWebSrc to WEBKIT_DEFINE_TYPE : [Attachment 384446] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 28 03:51:27 PST 2019


Carlos Garcia Campos <cgarcia at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 204674: [GStreamer] Convert GLVideoSink and WebKitWebSrc to
WEBKIT_DEFINE_TYPE
https://bugs.webkit.org/show_bug.cgi?id=204674

Attachment 384446: Patch

https://bugs.webkit.org/attachment.cgi?id=384446&action=review




--- Comment #2 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 384446
  --> https://bugs.webkit.org/attachment.cgi?id=384446
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384446&action=review

> Source/WebCore/platform/graphics/gstreamer/GLVideoSinkGStreamer.cpp:78
> +    GST_DEBUG_CATEGORY_INIT(webkit_gl_video_sink_debug, "webkitglvideosink",
0, "GL video sink element"));

We don't need the ;

> Source/WebCore/platform/graphics/gstreamer/GLVideoSinkGStreamer.cpp:121
> +    GST_CALL_PARENT(G_OBJECT_CLASS, constructed, (object));

Do this at the beginning, in the case of constructed we want to construct the
parent first.

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:187
> +);

We don't need the ;

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:273
> +    GST_CALL_PARENT(G_OBJECT_CLASS, constructed, (object));

Same here, do this at the beginning.


More information about the webkit-reviews mailing list