[webkit-reviews] review denied: [Bug 204407] Move some alignment tests to the wpt folder : [Attachment 384050] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Nov 28 02:19:22 PST 2019
Manuel Rego Casasnovas <rego at igalia.com> has denied rmonteriso at igalia.com's
request for review:
Bug 204407: Move some alignment tests to the wpt folder
https://bugs.webkit.org/show_bug.cgi?id=204407
Attachment 384050: Patch
https://bugs.webkit.org/attachment.cgi?id=384050&action=review
--- Comment #7 from Manuel Rego Casasnovas <rego at igalia.com> ---
Comment on attachment 384050
--> https://bugs.webkit.org/attachment.cgi?id=384050
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=384050&action=review
> LayoutTests/ChangeLog:10
> + * fast/css-grid-layout/grid-align-content.html: Removed.
You need to remove the -expected.txt files too.
> LayoutTests/imported/w3c/ChangeLog:11
> + * web-platform-tests/css/css-grid/alignment/grid-align-content.html:
We need to include in the patch the new results for the tests.
More information about the webkit-reviews
mailing list