[webkit-reviews] review denied: [Bug 204602] [Web Animations] Layout of children of element with forwards-filling opacity animation may be incorrect after removal : [Attachment 384335] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Antoine Quint
<graouts at apple.com>'s request for review:
Bug 204602: [Web Animations] Layout of children of element with
forwards-filling opacity animation may be incorrect after removal
https://bugs.webkit.org/show_bug.cgi?id=204602

Attachment 384335: Patch

https://bugs.webkit.org/attachment.cgi?id=384335&action=review




--- Comment #10 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 384335
  --> https://bugs.webkit.org/attachment.cgi?id=384335
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384335&action=review

> Source/WebCore/rendering/RenderLayerModelObject.cpp:192
> +	       parentLayer->updateLayerPositionsAfterStyleChange();

Nooo, you can't call this here. This needs to happen after the entire style
update. This is why we need some new RenderStyle::Diff values.