[webkit-reviews] review granted: [Bug 204602] [Web Animations] Layout of children of element with forwards-filling opacity animation may be incorrect after removal : [Attachment 384332] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Nov 26 00:46:33 PST 2019
Antti Koivisto <koivisto at iki.fi> has granted Antoine Quint
<graouts at apple.com>'s request for review:
Bug 204602: [Web Animations] Layout of children of element with
forwards-filling opacity animation may be incorrect after removal
https://bugs.webkit.org/show_bug.cgi?id=204602
Attachment 384332: Patch
https://bugs.webkit.org/attachment.cgi?id=384332&action=review
--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 384332
--> https://bugs.webkit.org/attachment.cgi?id=384332
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=384332&action=review
> Source/WebCore/rendering/RenderLayerModelObject.cpp:188
> + // If the layer we're about to destroy had a position, then the
layout of children will no longer be correct.
> + bool layerHadLocation = !layer()->location().isZero();
I wonder if there is some existing way to just update layer positions instead
of triggering a layout in render tree...
More information about the webkit-reviews
mailing list