[webkit-reviews] review denied: [Bug 203288] MediaQueryList should extend EventTarget : [Attachment 384151] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 25 17:49:13 PST 2019

Sam Weinig <sam at webkit.org> has denied Alexey Shvayka <shvaikalesh at gmail.com>'s
request for review:
Bug 203288: MediaQueryList should extend EventTarget

Attachment 384151: Patch


--- Comment #4 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 384151
  --> https://bugs.webkit.org/attachment.cgi?id=384151

View in context: https://bugs.webkit.org/attachment.cgi?id=384151&action=review

> Source/WebCore/css/MediaQueryList.cpp:60
> +    addEventListener("change", listener.releaseNonNull());

The IDL declares the listener parameter as optional, so I don't think you can
remove the null check if you are going to keep this listener.releaseNonNull().
Same with removeListener below.

More information about the webkit-reviews mailing list