[webkit-reviews] review granted: [Bug 204594] [LFC][IFC] Use FontCascade::spaceWidth to measure single or collapsed whitespace content : [Attachment 384318] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 204594: [LFC][IFC] Use FontCascade::spaceWidth to measure single or
collapsed whitespace content
https://bugs.webkit.org/show_bug.cgi?id=204594

Attachment 384318: Patch

https://bugs.webkit.org/attachment.cgi?id=384318&action=review




--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 384318
  --> https://bugs.webkit.org/attachment.cgi?id=384318
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384318&action=review

> Source/WebCore/layout/inlineformatting/InlineTextItem.cpp:118
> +	       auto width = simpleSingleWhitespaceContent ?
Optional<LayoutUnit>(LayoutUnit { font.spaceWidth() }) :
inlineItemWidth(currentPosition, length);

Shorter:

makeOptional(LayoutUnit { font.spaceWidth() })