[webkit-reviews] review granted: [Bug 204592] [Win] Ensure MiniBrowser can be built with !ENABLE(WEBKIT_LEGACY) : [Attachment 384315] Patch

[bugzilla-daemon at webkit.org]

Don Olmstead <don.olmstead at sony.com> has granted Ross Kirsling
<ross.kirsling at sony.com>'s request for review:
Bug 204592: [Win] Ensure MiniBrowser can be built with !ENABLE(WEBKIT_LEGACY)
https://bugs.webkit.org/show_bug.cgi?id=204592

Attachment 384315: Patch

https://bugs.webkit.org/attachment.cgi?id=384315&action=review




--- Comment #3 from Don Olmstead <don.olmstead at sony.com> ---
Comment on attachment 384315
  --> https://bugs.webkit.org/attachment.cgi?id=384315
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384315&action=review

Fix the nits and we can merge assuming Apple folks have no complaints.

> Tools/MiniBrowser/win/WinMain.cpp:46
> +#include "WebKitLegacyBrowserWindow.h"

Know this is copy pasta but any reason why this isn't angle brackets?

> Tools/PlatformWin.cmake:6
> +if (ENABLE_WEBKIT OR ENABLE_WEBKIT_LEGACY)
> +    add_subdirectory(MiniBrowser/win)
> +endif ()
> +

You can probably just `add_subdirectory` here since its always going to be
true.