[webkit-reviews] review granted: [Bug 204565] Queuing a task in EventLoop is not working with UserMediaRequest allow completion handler : [Attachment 384277] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 25 13:57:38 PST 2019


Ryosuke Niwa <rniwa at webkit.org> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 204565: Queuing a task in EventLoop is not working with UserMediaRequest
allow completion handler
https://bugs.webkit.org/show_bug.cgi?id=204565

Attachment 384277: Patch

https://bugs.webkit.org/attachment.cgi?id=384277&action=review




--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 384277
  --> https://bugs.webkit.org/attachment.cgi?id=384277
Patch

Interesting. I wonder if this is a common pattern. If so, we can add a variant
of queueTaskKeepingObjectAlive which takes a completion handler & automatically
calls it in the case the task is dropped because the event loop knows when an
active DOM object is stopped.


More information about the webkit-reviews mailing list