[webkit-reviews] review granted: [Bug 204556] [JSC] InternalFunction should be non-destructible : [Attachment 384278] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 25 08:56:19 PST 2019

Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 204556: [JSC] InternalFunction should be non-destructible

Attachment 384278: Patch


--- Comment #13 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 384278
  --> https://bugs.webkit.org/attachment.cgi?id=384278

View in context: https://bugs.webkit.org/attachment.cgi?id=384278&action=review

r=me if EWS bots are green.

> Source/JavaScriptCore/ChangeLog:11
> +	   InternalFunction should be non-destructible since nobody is using
destroy function.
> +	   If it is defined, it should have different IsoSubspace. We annotate
needsDestruction = true for
> +	   these classes. And we define HeapCellType for each such a type, and
pass it to IsoSubspace to
> +	   invoke appropriate destructor.

I suggest rephrasing this as:

InternalFunction and most of its subclasses should be non-destructible since
they can be trivially destructed and don't use a destroy function.  For the few
subclasses that do need a destroy function, these should have different
IsoSubspaces of their own.  For each of these subclasses, we annotate
needsDestruction = true, define a specific HeapCellType for them, and pass the
HeapCellType to their IsoSubspace so that their destructors can be invoked.

More information about the webkit-reviews mailing list