[webkit-reviews] review canceled: [Bug 202183] [Win] Update KeyboardEvent as per the latest specification : [Attachment 384037] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Nov 24 19:36:11 PST 2019


Fujii Hironori <Hironori.Fujii at sony.com> has canceled Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 202183: [Win] Update KeyboardEvent as per the latest specification
https://bugs.webkit.org/show_bug.cgi?id=202183

Attachment 384037: Patch

https://bugs.webkit.org/attachment.cgi?id=384037&action=review




--- Comment #26 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 384037
  --> https://bugs.webkit.org/attachment.cgi?id=384037
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384037&action=review

>> Source/WebCore/platform/win/WindowsKeyNames.h:39
>> +template<typename T> struct DefaultHash<OptionSet<T>> {
> 
> Hmm, wouldn't this need to go in wtf/OptionSet.h?

Fair enough. I should do it.
Filed: Bug 204562 – Add DefaultHash<OptionSet<T>> and HashTrait<OptionSet<T>>
specializations


More information about the webkit-reviews mailing list