[webkit-reviews] review granted: [Bug 204389] Resource Load Statistics: Allow multiple third-party cookie blocking settings : [Attachment 384210] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Nov 23 17:15:11 PST 2019


Brent Fulgham <bfulgham at webkit.org> has granted John Wilander
<wilander at apple.com>'s request for review:
Bug 204389: Resource Load Statistics: Allow multiple third-party cookie
blocking settings
https://bugs.webkit.org/show_bug.cgi?id=204389

Attachment 384210: Patch

https://bugs.webkit.org/attachment.cgi?id=384210&action=review




--- Comment #10 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 384210
  --> https://bugs.webkit.org/attachment.cgi?id=384210
Patch

Thank you for making the database and memory stores match. Everything else
looks fine.

I don’t understand the Mac-debug-wk1 failures, but they do not seem related to
your patch. Please keep an eye on the test bits after you land the patch and
confirm they are unrelated.


More information about the webkit-reviews mailing list