[webkit-reviews] review granted: [Bug 204391] Run LayoutTests/accessibility/mac/primary-screen-height.html on secondary accessibility thread. : [Attachment 383932] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Nov 23 00:19:43 PST 2019


chris fleizach <cfleizach at apple.com> has granted Andres Gonzalez
<andresg_22 at apple.com>'s request for review:
Bug 204391: Run LayoutTests/accessibility/mac/primary-screen-height.html on
secondary accessibility thread.
https://bugs.webkit.org/show_bug.cgi?id=204391

Attachment 383932: Patch

https://bugs.webkit.org/attachment.cgi?id=383932&action=review




--- Comment #2 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 383932
  --> https://bugs.webkit.org/attachment.cgi?id=383932
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383932&action=review

> Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:375
> +	   NSArray* children = [m_element
accessibilityArrayAttributeValues:NSAccessibilityChildrenAttribute
index:location maxCount:length];

NSArray *children

(pointer on wrong side)


More information about the webkit-reviews mailing list