[webkit-reviews] review granted: [Bug 204542] REGRESSION (r252792?): 6 inspector/canvas tests crashing : [Attachment 384220] Fixes the bug

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 22 18:52:43 PST 2019


Devin Rousso <drousso at apple.com> has granted  review:
Bug 204542: REGRESSION (r252792?): 6 inspector/canvas tests crashing
https://bugs.webkit.org/show_bug.cgi?id=204542

Attachment 384220: Fixes the bug

https://bugs.webkit.org/attachment.cgi?id=384220&action=review




--- Comment #10 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 384220
  --> https://bugs.webkit.org/attachment.cgi?id=384220
Fixes the bug

r=me, this actually should be enough as we shouldn’t be adding anything to
`m_recordingCanvasIdentifiers` in this loop. If anything, it should already be
empty at the end of this loop since each item gets removed inside
`InspectorCanvasAgent::didFinishRecordingCanvasFrame`.

Thanks for the quick fix!


More information about the webkit-reviews mailing list