[webkit-reviews] review granted: [Bug 204361] HTTPHeaderMap's operator== is not fully correct : [Attachment 383883] Simpler Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 22 15:09:45 PST 2019

Alex Christensen <achristensen at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 204361: HTTPHeaderMap's operator== is not fully correct

Attachment 383883: Simpler Patch


--- Comment #28 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 383883
  --> https://bugs.webkit.org/attachment.cgi?id=383883
Simpler Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383883&action=review

> Source/WebCore/platform/network/HTTPHeaderMap.h:193
> +	   if (a.m_commonHeaders.size() != b.m_commonHeaders.size() ||
a.m_uncommonHeaders.size() != b.m_uncommonHeaders.size())

It might be worth adding another fast path for if the vectors are actually
equal, to have a O(N) possibility that returns true.

More information about the webkit-reviews mailing list