[webkit-reviews] review denied: [Bug 204460] Null check callback in NetworkConnectionToWebProcess::didDeliverMessagePortMessages : [Attachment 384185] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has denied Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 204460: Null check callback in
NetworkConnectionToWebProcess::didDeliverMessagePortMessages
https://bugs.webkit.org/show_bug.cgi?id=204460

Attachment 384185: Patch

https://bugs.webkit.org/attachment.cgi?id=384185&action=review




--- Comment #10 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 384185
  --> https://bugs.webkit.org/attachment.cgi?id=384185
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384185&action=review

> Source/WebKit/ChangeLog:10
> +	   a web process may have an identifier that becomes stale.  In this
case, we should not crsah again.

Typo: crash

> Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:1001
> +	   ASSERT_NOT_REACHED();

Since we know this can happen in practice and we have a valid explanation for
it, I do not think we should ASSERT.