[webkit-reviews] review granted: [Bug 204521] Media queries in img sizes attribute don't evaluate dynamically : [Attachment 384161] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 22 12:47:28 PST 2019

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 204521: Media queries in img sizes attribute don't evaluate dynamically

Attachment 384161: patch


--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 384161
  --> https://bugs.webkit.org/attachment.cgi?id=384161

View in context: https://bugs.webkit.org/attachment.cgi?id=384161&action=review

> LayoutTests/fast/images/sizes-dynamic-001.html:5
> +<link rel="match" href="sizes-dynamic-001-ref.html">

Please fix this to point to the real ref file.

> LayoutTests/fast/images/sizes-dynamic-002.html:5
> +<link rel="match" href="sizes-dynamic-001-ref.html">


> Source/WebCore/dom/Document.h:1829
> +    HashSet<HTMLImageElement*> m_dynamicMediaQueryDependentImages;

Are we still using raw pointers for stuff like this?

More information about the webkit-reviews mailing list