[webkit-reviews] review granted: [Bug 204361] HTTPHeaderMap's operator== is not fully correct : [Attachment 384183] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 204361: HTTPHeaderMap's operator== is not fully correct
https://bugs.webkit.org/show_bug.cgi?id=204361

Attachment 384183: Patch

https://bugs.webkit.org/attachment.cgi?id=384183&action=review




--- Comment #17 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 384183
  --> https://bugs.webkit.org/attachment.cgi?id=384183
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384183&action=review

> Source/WebCore/platform/network/HTTPHeaderMap.h:202
> +	   std::sort(a.m_uncommonHeaders.begin(), a.m_uncommonHeaders.end(),
[](auto& headerA, auto& headerB) { return
WTF::codePointCompareLessThan(headerA.key, headerB.key); });
> +	   std::sort(b.m_uncommonHeaders.begin(), b.m_uncommonHeaders.end(),
[](auto& headerA, auto& headerB) { return
WTF::codePointCompareLessThan(headerA.key, headerB.key); });

You should be able to just put WTF::codePointCompareLessThan instead of a
lambda that wraps it.