[webkit-reviews] review granted: [Bug 204526] run-javascriptcore-tests: Failure to determine configuration for reporting is fatal : [Attachment 384173] Patch

[bugzilla-daemon at webkit.org]

Aakash Jain <aakash_jain at apple.com> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 204526: run-javascriptcore-tests: Failure to determine configuration for
reporting is fatal
https://bugs.webkit.org/show_bug.cgi?id=204526

Attachment 384173: Patch

https://bugs.webkit.org/attachment.cgi?id=384173&action=review




--- Comment #2 from Aakash Jain <aakash_jain at apple.com> ---
Comment on attachment 384173
  --> https://bugs.webkit.org/attachment.cgi?id=384173
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384173&action=review

> Tools/Scripts/run-javascriptcore-tests:880
> +    if (!keys $configuration) {

is this tested?