[webkit-reviews] review granted: [Bug 204411] [JSConly] 32-bits warning on memset of JSValue : [Attachment 384163] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 22 10:13:33 PST 2019

Mark Lam <mark.lam at apple.com> has granted Paulo Matos <pmatos at igalia.com>'s
request for review:
Bug 204411: [JSConly] 32-bits warning on memset of JSValue

Attachment 384163: Patch


--- Comment #10 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 384163
  --> https://bugs.webkit.org/attachment.cgi?id=384163

View in context: https://bugs.webkit.org/attachment.cgi?id=384163&action=review

r=me with fix.

> Source/JavaScriptCore/heap/GCMemoryOperations.h:256
> +    RELEASE_ASSERT(bytes % 8 == 0);

Please remove this RELEASE_ASSERT.  It's not necessarily free and it's
redundant with the one at the top of gcSafeZeroMemory().  You can make it a
debug ASSERT.

More information about the webkit-reviews mailing list