[webkit-reviews] review granted: [Bug 204514] [LFC][IFC] Line::Run::expand should take a range of runs to merge : [Attachment 384150] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 204514: [LFC][IFC] Line::Run::expand should take a range of runs to merge
https://bugs.webkit.org/show_bug.cgi?id=204514

Attachment 384150: Patch

https://bugs.webkit.org/attachment.cgi?id=384150&action=review




--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 384150
  --> https://bugs.webkit.org/attachment.cgi?id=384150
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384150&action=review

> Source/WebCore/layout/inlineformatting/InlineLine.cpp:315
> +	       auto& trailingRun = m_inlineItemRuns[i + 1];
> +	       if (!ContinousContent::canMergeRuns(*m_inlineItemRuns[i],
*trailingRun))
>		   break;
> -	       runList.last().expand(*nextRun);
> -	       // Skip the merged run.
> -	       ++i;
> +	       continousContent.append(*trailingRun);

Maybe the canMergeRuns call could be done in ContinousContent too? Like instead
of append do something like

continousContent.mergeIfNeeded(*m_inlineItemRuns[i], m_inlineItemRuns[i + 1]);