[webkit-reviews] review granted: [Bug 204494] replaceUsingStringSearch() should not use CachedCall with host functions. : [Attachment 384128] proposed patch.

[bugzilla-daemon at webkit.org]

Ross Kirsling <ross.kirsling at sony.com> has granted Mark Lam
<mark.lam at apple.com>'s request for review:
Bug 204494: replaceUsingStringSearch() should not use CachedCall with host
functions.
https://bugs.webkit.org/show_bug.cgi?id=204494

Attachment 384128: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=384128&action=review




--- Comment #2 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 384128
  --> https://bugs.webkit.org/attachment.cgi?id=384128
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=384128&action=review

> Source/JavaScriptCore/runtime/StringPrototype.cpp:812
> -	       if (cachedCall) {
> +	       if (callType == CallType::JS) {

Might be clearer to leave this line -- then the branch reads as "if we have a
cached call then call it".