[webkit-reviews] review granted: [Bug 204395] Web Inspector: Canvas: adjust `InspectorCanvasAgent::recordCanvasAction` to actually check that the `CanvasRenderingContext` still exists : [Attachment 384123] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 204395: Web Inspector: Canvas: adjust
`InspectorCanvasAgent::recordCanvasAction` to actually check that the
`CanvasRenderingContext` still exists
https://bugs.webkit.org/show_bug.cgi?id=204395

Attachment 384123: Patch

https://bugs.webkit.org/attachment.cgi?id=384123&action=review




--- Comment #14 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 384123
  --> https://bugs.webkit.org/attachment.cgi?id=384123
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384123&action=review

The mechanism WeakPtr part of the change looks good but perhaps someone
familiar with WebInspector should also review this code change too.

> Source/WebCore/inspector/agents/InspectorCanvasAgent.cpp:454
> +	       scriptExecutionContext->eventLoop().queueMicrotask([weakThis =
makeWeakPtr(*this)] {

This change makes sense to me.