[webkit-reviews] review granted: [Bug 204379] IndexedDB: lock-based implementation of suspension : [Attachment 384106] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 21 17:18:17 PST 2019

Geoffrey Garen <ggaren at apple.com> has granted  review:
Bug 204379: IndexedDB: lock-based implementation of suspension

Attachment 384106: Patch


--- Comment #11 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 384106
  --> https://bugs.webkit.org/attachment.cgi?id=384106

View in context: https://bugs.webkit.org/attachment.cgi?id=384106&action=review


> Source/WebCore/Modules/indexeddb/server/IDBServer.h:196
> +    HashSet<UniqueIDBDatabase*> m_allUniqueIDBDatabases;

It would be better to use a WeakHashSet. That way, you don't need
registerDatabase / unregisterDatabase, and you have pointer safety by default.

> Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.h:273
> +    Lock m_backingStoreLock;

Would be nice to add a comment explaining that the purpose of this lock is to
synchronize vs suspension.

More information about the webkit-reviews mailing list