[webkit-reviews] review granted: [Bug 204468] A video element cannot enter fullscreen from PiP mode : [Attachment 384092] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Peng Liu
<peng.liu6 at apple.com>'s request for review:
Bug 204468: A video element cannot enter fullscreen from PiP mode
https://bugs.webkit.org/show_bug.cgi?id=204468

Attachment 384092: Patch

https://bugs.webkit.org/attachment.cgi?id=384092&action=review




--- Comment #5 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 384092
  --> https://bugs.webkit.org/attachment.cgi?id=384092
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384092&action=review

> Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm:1474
> -	   m_videoFullscreenModel->fullscreenModeChanged(m_currentMode.mode());
> +	   m_videoFullscreenModel->fullscreenModeChanged(mode);

It's probably worth adding a comment about why you are making this change, IOW
why does "m_currentMode.mode()" not return "mode" immediately after calling
"m_currentMode.setMode(mode)"