[webkit-reviews] review granted: [Bug 204435] GetByStatus should not say it took the slow path for multiple identifiers and should have a way to indicate if the StructureStubInfo it saw took the slow path : [Attachment 384097] patch

[bugzilla-daemon at webkit.org]

Tadeu Zagallo <tzagallo at apple.com> has granted Saam Barati
<sbarati at apple.com>'s request for review:
Bug 204435: GetByStatus should not say it took the slow path for multiple
identifiers and should have a way to indicate if the StructureStubInfo it saw
took the slow path
https://bugs.webkit.org/show_bug.cgi?id=204435

Attachment 384097: patch

https://bugs.webkit.org/attachment.cgi?id=384097&action=review




--- Comment #2 from Tadeu Zagallo <tzagallo at apple.com> ---
Comment on attachment 384097
  --> https://bugs.webkit.org/attachment.cgi?id=384097
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384097&action=review

r=me.

> Source/JavaScriptCore/ChangeLog:24
> +	   between a GetByStatus saying "we're a slow path" and if we actually
observed the StructureStubInfo
> +	   go to the slow path. In the DFG/FTL, we only forgo emitting a get by
val IC when observing a

Maybe it's just me, but I found this a bit confusing throughout the patch. It's
kinda weird that we say it's a slow path if the slow path wasn't taken, but I'm
not sure what would be a better alternative, so I'll leave it to you to decide
whether it makes sense or not.