[webkit-reviews] review granted: [Bug 204459] Crash in com.apple.WebKit.WebContent at WebKit: WebKit::StorageAreaMap::loadValuesIfNeeded : [Attachment 384066] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 21 10:47:18 PST 2019


Geoffrey Garen <ggaren at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 204459: Crash in com.apple.WebKit.WebContent at WebKit:
WebKit::StorageAreaMap::loadValuesIfNeeded
https://bugs.webkit.org/show_bug.cgi?id=204459

Attachment 384066: Patch

https://bugs.webkit.org/attachment.cgi?id=384066&action=review




--- Comment #3 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 384066
  --> https://bugs.webkit.org/attachment.cgi?id=384066
Patch

r=me

Perhaps we should null check m_storageMapID in other functions too. That said,
there's no obviously correct behavior in this surprising situation.


More information about the webkit-reviews mailing list