[webkit-reviews] review granted: [Bug 200904] Implement accelerated video-to-texture upload path for ANGLE backend for WebGL on desktop : [Attachment 383207] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Kenneth Russell <kbr at google.com>'s
request for review:
Bug 200904: Implement accelerated video-to-texture upload path for ANGLE
backend for WebGL on desktop
https://bugs.webkit.org/show_bug.cgi?id=200904

Attachment 383207: Patch

https://bugs.webkit.org/attachment.cgi?id=383207&action=review




--- Comment #6 from Dean Jackson <dino at apple.com> ---
Comment on attachment 383207
  --> https://bugs.webkit.org/attachment.cgi?id=383207
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383207&action=review

I'll land manually.

> Source/WebCore/ChangeLog:13
> +	   Uses the EGL_ANGLE_iosurface_client_buffer extension to import
> +	   IOSurfaces; reuses all of the existing shader and OpenGL code.

Not important to this patch, but I'll mention to anyone watching that we don't
yet have a solution for this in the iOS simulator (where we cannot bind
IOSurface to GL).

> Source/WebCore/platform/graphics/GraphicsContext3D.h:748
> +	   // Necessary desktop OpenGL constants

Nit: End with period.