[webkit-reviews] review granted: [Bug 204422] Experimental support for HDR media query : [Attachment 384017] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 204422: Experimental support for HDR media query
https://bugs.webkit.org/show_bug.cgi?id=204422

Attachment 384017: Patch

https://bugs.webkit.org/attachment.cgi?id=384017&action=review




--- Comment #7 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 384017
  --> https://bugs.webkit.org/attachment.cgi?id=384017
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384017&action=review

> Source/WebCore/css/MediaQueryExpression.cpp:61
> +    || mediaFeature == MediaFeatureNames::dynamicRange;

Shouldn't this consider hdrMediaCapabilitiesEnabled?

> Source/WebCore/platform/cocoa/MediaToolboxSoftLink.cpp:35
> +SOFT_LINK_FRAMEWORK_FOR_SOURCE(WebCore, MediaToolbox)
> +
> +SOFT_LINK_FUNCTION_MAY_FAIL_FOR_SOURCE(WebCore, MediaToolbox,
MTShouldPlayHDRVideo, Boolean, (CFArrayRef displayList), (displayList))

Is there any reason to not put this in PAL?